Switch //net SocketDataProviders to base::span<>
Currently, the SocketDataProvider interfaces in //net their parameters
in the generalized form of (T* stuff, size_t stuff_len) pairs of
arguments. Rather than use this error-prone pattern, switch it over
to base::span<> and propagate it through to callers and their respective
functions.
This has the side-effect of substantially reducing the use of arraysize()
in //net, thus reducing the risk of tripping the PRESUBMIT warning as part
of https://crbug.com/837308
BUG=837308
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic4f950f149b11061e819b546f3a6d45fc0216f58
Reviewed-on: https://chromium-review.googlesource.com/1045798
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Helen Li <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#556538}diff --git a/net/websockets/websocket_test_util.cc b/net/websockets/websocket_test_util.cc
index a9baa51f..5528be8 100644
--- a/net/websockets/websocket_test_util.cc
+++ b/net/websockets/websocket_test_util.cc
@@ -183,7 +183,7 @@
sequence++));
}
auto socket_data = std::make_unique<SequencedSocketData>(
- detail_->reads.data(), detail_->reads.size(), &detail_->write, 1);
+ detail_->reads, base::make_span(&detail_->write, 1));
socket_data->set_connect_data(MockConnect(SYNCHRONOUS, OK));
AddRawExpectations(std::move(socket_data));
}
