Google Git
Sign in
chromium / chromium / src.git / d15cc1c7ca5f3a58d0d299ef6fd287d610082eea
commitd15cc1c7ca5f3a58d0d299ef6fd287d610082eea[log] [tgz]
authorNicholas Verne <[email protected]>Mon Dec 02 22:38:57 2019
committerCommit Bot <[email protected]>Mon Dec 02 22:38:57 2019
tree188f505b7ea50600c30cfdb2bc5b7ceff29365cd
parentc720e39adb9d570fc977b0799f74542259211e36 [diff]
Creates a WebUI-based Crostini Upgrader

This time with tools/gritsettings/resource_ids. Why this is not in a PRESUBMIT
for all .grd files is a mystery.

The UI is behind the new crostini-webui-upgrader flag
(currently disabled by default)

The main areas for review are

calamity@:
html/js  - chrome/browser/chromeos/crostini_upgrader/
mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/

davidmunro@
crostini business logic - chrome/browser/chromeos/crostini/

In this CL, the optional container backup stage is stubbed, and will be
in a subsequent CL.

A suite of unit/browser tests are also currently lacking. I intend them for
follow-up CLs.


Bug: 930901
Change-Id: I5dd3f838e144c7f705ef2be1af5ac5f5afdf3f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933583
Commit-Queue: Ken Rockot <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Reviewed-by: calamity <[email protected]>
Auto-Submit: Nicholas Verne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#720697}
31 files changed
tree: 188f505b7ea50600c30cfdb2bc5b7ceff29365cd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .