Google Git
Sign in
chromium / chromium / src.git / ba3eecbf23feeea636e323dbd0e91e7a54e87263
commitba3eecbf23feeea636e323dbd0e91e7a54e87263[log] [tgz]
authorRakina Zata Amni <[email protected]>Mon Nov 02 10:12:28 2020
committerCommit Bot <[email protected]>Mon Nov 02 10:12:28 2020
treeed73a416a56e2c64b45582827a1b19e0905dbc53
parent6239e056ec7c384206564fda8f2221fd311250b8 [diff]
Add a new NavigationThrottle for HTTP-error navigations with empty body

Previously, error page navigations initiated by the renderer will commit
synchronously and only notify the browser at DidCommit time, making it
have to create a NavigationRequest for the navigation at DidCommit time.
One of the cases that do that is main-frame navigations with error HTTP
status code and an empty response body.

This CL makes it so that we detect that case in the browser side instead
of the renderer side by adding a NavigationThrottle that will defer main
frame navigations with an error HTTP status code until we can determine
if its response body is empty or not, and commit an error page instead
of the original (empty) page if so.

For more context:
doc: https://docs.google.com/document/d/1hf7b7OWlJMCpfFBk3xgxzHnskyNx3X8qjNWg6M1hr_0/edit

navigation-dev thread: https://groups.google.com/a/chromium.org/g/navigation-dev/c/WbNkf2alpPU/m/2tQQ-cXWBgAJ

Bug: 1133115
Change-Id: I09998edd984b86bad6294edc4c83a32c31e0197f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487024
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#823093}
47 files changed
tree: ed73a416a56e2c64b45582827a1b19e0905dbc53
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.