Google Git
Sign in
chromium / chromium / src.git / ba74f8161fe7154cd9f3ed5a3bfa8c65bbae48c2
commitba74f8161fe7154cd9f3ed5a3bfa8c65bbae48c2[log] [tgz]
authorAlan Cutter <[email protected]>Thu Jul 09 05:16:54 2020
committerCommit Bot <[email protected]>Thu Jul 09 05:16:54 2020
tree16b28d7deb9e1ac7b2cc9742933d100c1a7bc6ed
parent2833feb6ae3e429ccbdd3f49ccb5cf6a25b80d79 [diff]
Avoid "open link in app" menu entries if BrowserAppLauncher() is nullptr

This CL refactors the check in
RenderViewContextMenu::AppendOpenInWebAppLinkItems() to test
BrowserAppLauncher() for nullptr directly rather than testing for
incognito profile.

This requires updating AppServiceProxy::BrowserAppLauncher() to return
a pointer rather than a reference.

Bug: 1100255
Change-Id: I0242ea0df9b77428159e8f4b0b9a6eaef4c6f32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275282
Commit-Queue: Alan Cutter <[email protected]>
Auto-Submit: Alan Cutter <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#786638}
41 files changed
tree: 16b28d7deb9e1ac7b2cc9742933d100c1a7bc6ed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.