| commit | bbaacbe524515e8eafcd04f6dc6d872d403ffed6 | [log] [tgz] |
|---|---|---|
| author | paulmeyer <[email protected]> | Tue Aug 30 18:04:13 2016 |
| committer | Commit bot <[email protected]> | Tue Aug 30 18:06:11 2016 |
| tree | b776d15994c64be36dde86bc96a3ba1769ef6aa3 | |
| parent | 691e5d283a74fcc59967008d17f6068d071952fe [diff] |
Changes to how FindRequestManager reports find results. I've noticed some problematic edge cases with the reporting of find-in-page results from FindRequestManager. While trying to write some new tests in find_request_manager_browsertest.cc, I noticed that the new tests sometimes fail because of these edge cases. The existing tests in there could definitely fail from this as well, though much less likely. I have seen them fail very rarely before though and this is probably why. The details of the issue, edge cases, and my solution are explained in this design doc: https://docs.google.com/a/google.com/document/d/1BCvuSW9XSBH7GMx5VC0TgBh6XmJJDOzz_XZKItjF6oM/edit?usp=sharing UPDATE: Anther find-in-page CL I landed recently (https://codereview.chromium.org/2186113002/) was reverted because of a test that began timing out. I believe that failure is caused by the problems fixed here, so that bugfix is now blocked on this CL. Review-Url: https://codereview.chromium.org/2249133002 Cr-Commit-Position: refs/heads/master@{#415353}