Google Git
Sign in
chromium / chromium / src.git / 4307cbaecf878169169ed36211e8d26786f52bf6
commit4307cbaecf878169169ed36211e8d26786f52bf6[log] [tgz]
authorMohammad Refaat <[email protected]>Wed May 29 15:25:15 2019
committerCommit Bot <[email protected]>Wed May 29 15:25:15 2019
tree83a07c2be46bfe7277d4684828de90edb9cb4291
parentf6d580ba63c8d1d99597cc8f2bd347d624796546 [diff]
Remove TabModelObserver usage from TabStripController.

The last method from didChangeTab which was used to update tab title
and update the loading spinner.
Instead of using TabModelObserver didChangeTab, use WebStateObserver to
monitor all webStates and use didStartLoading/didStopLoading to update
the spinner. Also use WebStateObserver didChangeTitle to update the
tabview title.

Bug: 911350
Change-Id: Ie1b0bfc77d7dca39e27e6efb6e8478aaaf9e9a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630628
Commit-Queue: Mohammad Refaat <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#664280}
1 file changed
tree: 83a07c2be46bfe7277d4684828de90edb9cb4291
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .