| commit | bc672a07dde1969b28a79f92262a873c3f54eaed | [log] [tgz] |
|---|---|---|
| author | Jared Saul <[email protected]> | Sat Jun 16 05:22:12 2018 |
| committer | Commit Bot <[email protected]> | Sat Jun 16 05:22:12 2018 |
| tree | fdae78eaea4217f4c4d8ada8f064ef62a7781b94 | |
| parent | 6e803258b86e365b66e8ae3cb561efb0f03d64ab [diff] [blame] |
[Autofill] Request cardholder name in the credit card upload save bubble under certain conditions For Milestone 4 of the Partial Data Project, Chrome should explicitly request that the user confirms their cardholder name (prepopulated with the name from their Google Account) when name is missing and the user does not have a Google Payments account. This CL is actually going to be extremely similar to the original CVC fix flow, which was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1034103. Feel free to cross-reference these CLs, as most everything I took out in that CL is simply getting put back in this one, except this time it's name instead of CVC. Surprise! Bug: 848955 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I08e94c1a16b7b1da403ea5a8f26d1e2d423c210e Reviewed-on: https://chromium-review.googlesource.com/1083880 Commit-Queue: Jared Saul <[email protected]> Reviewed-by: Evan Stade <[email protected]> Reviewed-by: Rachel Blum <[email protected]> Reviewed-by: John Wu <[email protected]> Reviewed-by: Moe Ahmadi <[email protected]> Reviewed-by: Sebastien Seguin-Gagnon <[email protected]> Reviewed-by: Richard Coles <[email protected]> Reviewed-by: Roger Tawa <[email protected]> Cr-Commit-Position: refs/heads/master@{#567876}
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h index 3cd265b..995f691 100644 --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h
@@ -231,6 +231,10 @@ extern const char kEnableAutofillCreditCardLastUsedDateDisplayName[]; extern const char kEnableAutofillCreditCardLastUsedDateDisplayDescription[]; +extern const char kEnableAutofillCreditCardUploadEditableCardholderNameName[]; +extern const char + kEnableAutofillCreditCardUploadEditableCardholderNameDescription[]; + extern const char kEnableAutofillCreditCardUploadGooglePayOnAndroidBrandingName[]; extern const char