| commit | bc6fdb0a984c5e2b807cd7fe442d246d328f5700 | [log] [tgz] |
|---|---|---|
| author | Ayu Ishii <[email protected]> | Mon Jun 08 22:59:19 2020 |
| committer | Commit Bot <[email protected]> | Mon Jun 08 22:59:19 2020 |
| tree | 8ab8d9b8d2bdea46b8a53d7fab1efbaface8cfab | |
| parent | 49519e75e05b7e468cb17773afb05fa51ac3be62 [diff] [blame] |
GetCookieList to return CookieAccessResultList
This change changes GetCookieList to return a list of a new struct
called CookieWithAccessResult instead of CookieWithStatus which
includes CookieEffectiveSameSite data as well as CookieInclusionStatus
but makes it available for extensibility to include other data from
cookie access time as well. The struct looks as follows.
struct CookieAccessResult {
CookieEffectiveSameSite effective_same_site;
CookieInclusionStatus status;
}
struct CookieWithAccessResult {
CanonicalCookie cookie;
CookieAccessResult access_result;
};
Bug: 1065010
Change-Id: I7ac01827fff511b422f5ff5a712d50d5a3885d17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212697
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Maksim Orlovich <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Reviewed-by: Bo <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Reviewed-by: Lily Chen <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#776249}
diff --git a/net/websockets/websocket_stream_cookie_test.cc b/net/websockets/websocket_stream_cookie_test.cc index 6e26562..f2e105f 100644 --- a/net/websockets/websocket_stream_cookie_test.cc +++ b/net/websockets/websocket_stream_cookie_test.cc
@@ -122,10 +122,10 @@ base::OnceClosure task, base::WeakPtr<bool> weak_is_called, base::WeakPtr<CookieList> weak_result, - const CookieStatusList& cookie_list, - const CookieStatusList& excluded_cookies) { + const CookieAccessResultList& cookie_list, + const CookieAccessResultList& excluded_cookies) { *weak_is_called = true; - *weak_result = cookie_util::StripStatuses(cookie_list); + *weak_result = cookie_util::StripAccessResults(cookie_list); base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, std::move(task)); } };