commit	bd3e986441c5d3dc38a97e76081f507501bc1236	[log] [tgz]
author	Avi Drissman <[email protected]>	Wed May 20 21:09:20 2020
committer	Commit Bot <[email protected]>	Wed May 20 21:09:20 2020
tree	3c239447ee0e5349af2ffb8d9a12206873df69d0
parent	496003a337b80fb2bb62606a6df5e55bedecb759 [diff]

Remove layering violation from FileChooserImpl

FileChooserImpl is-a WebContentsObserver, which violates layering.
Move it to web_contents where that’s OK.

Bug: 1076947
Change-Id: I62d97a0b2a85cc370b252627df1ad94fe8c711b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202787
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#770764}

content/browser/BUILD.gn[diff]
content/browser/browser_interface_binders.cc[diff]
content/browser/frame_host/DEPS[diff]
content/browser/frame_host/render_frame_host_delegate.cc[diff]
content/browser/frame_host/render_frame_host_delegate.h[diff]
content/browser/frame_host/render_frame_host_impl.cc[diff]
content/browser/frame_host/render_frame_host_impl.h[diff]
content/browser/frame_host/render_frame_host_impl_browsertest.cc[diff]
content/browser/security_exploit_browsertest.cc[diff]
content/browser/web_contents/file_chooser_impl.cc[Renamed from content/browser/frame_host/file_chooser_impl.cc - diff]
content/browser/web_contents/file_chooser_impl.h[Renamed from content/browser/frame_host/file_chooser_impl.h - diff]
content/browser/web_contents/file_chooser_impl_browsertest.cc[Added - diff]
content/browser/web_contents/web_contents_impl.h[diff]
content/test/BUILD.gn[diff]

14 files changed

tree: 3c239447ee0e5349af2ffb8d9a12206873df69d0

README.md

Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.