| commit | bea45544c228534f48393ff96e00c1354e14b87c | [log] [tgz] |
|---|---|---|
| author | Ramya Nagarajan <[email protected]> | Mon Apr 08 19:30:14 2019 |
| committer | Commit Bot <[email protected]> | Mon Apr 08 19:30:14 2019 |
| tree | c22198088421cc40ec265933b806c4a8493795cf | |
| parent | ca2ca03e89dbe9df255338a0757140007f7e74d0 [diff] [blame] |
Hard coded HideShortcutsOnNtp field trial for new users. Since field trials do not take effect until downloaded, they must be explicitly configured for any UI changes that would be visible upon first run. Additionally, the HideShortcuts feature is only activated upon a fresh install, and available to those clients after browser restart. More details at http://doc/1rYBoi6Hm270SB1njw3BhM3Qo9puZn3iiINQy-gMaz4I Bug: 944624 Change-Id: Icee61ba042ecc00b5f6e157ceace377ffad9486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537817 Reviewed-by: Lei Zhang <[email protected]> Reviewed-by: Alexei Svitkine <[email protected]> Reviewed-by: Kristi Park <[email protected]> Commit-Queue: Ramya Nagarajan <[email protected]> Cr-Commit-Position: refs/heads/master@{#648800}
diff --git a/chrome/browser/chrome_browser_field_trials.h b/chrome/browser/chrome_browser_field_trials.h index e80020b..5856c82 100644 --- a/chrome/browser/chrome_browser_field_trials.h +++ b/chrome/browser/chrome_browser_field_trials.h
@@ -8,13 +8,15 @@ #include "base/macros.h" #include "components/variations/platform_field_trials.h" +class PrefService; + namespace base { class FeatureList; } class ChromeBrowserFieldTrials : public variations::PlatformFieldTrials { public: - ChromeBrowserFieldTrials(); + explicit ChromeBrowserFieldTrials(PrefService* local_state); ~ChromeBrowserFieldTrials() override; // variations::PlatformFieldTrials: @@ -29,6 +31,9 @@ // reported as used. void InstantiateDynamicTrials(); + // Weak pointer to the local state prefs store. + PrefService* const local_state_; + DISALLOW_COPY_AND_ASSIGN(ChromeBrowserFieldTrials); };