Add flags for WebUI dark mode on Chrome OS
(1) features::kWebUIDarkMode. A base::Feature for this functionality
already existed, but it was not part of chrome://flags and was
difficult to enable for Chrome OS users. This CL adds an entry to
chrome://flags on Chrome OS.
(2) blink::features::kForceWebContentsDarkMode. This flag was present
in non-Chrome OS builds but was disabled on Chrome OS due to
https://crbug.com/1011696. This CL enables the flag for Chrome OS
but does not enable any variants/experiments for this platform.
Change-Id: Ie907255a95c09f3be70bd91f2eb850ca68a08c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486660
Reviewed-by: dpapad <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#819113}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e97bb61..bfc9a94 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -3527,16 +3527,17 @@
{"PasswordImport", flag_descriptions::kPasswordImportName,
flag_descriptions::kPasswordImportDescription, kOsAll,
FEATURE_VALUE_TYPE(password_manager::features::kPasswordImport)},
-#if !defined(OS_CHROMEOS)
- // TODO(https://crbug.com/1011696): Investigate crash reports and re-enable
- // for ChromeOS.
{"enable-force-dark", flag_descriptions::kForceWebContentsDarkModeName,
- flag_descriptions::kForceWebContentsDarkModeDescription,
- kOsWin | kOsLinux | kOsMac | kOsAndroid,
+ flag_descriptions::kForceWebContentsDarkModeDescription, kOsAll,
+#if defined(OS_CHROMEOS)
+ // TODO(https://crbug.com/1011696): Investigate crash reports and
+ // re-enable variations for ChromeOS.
+ FEATURE_VALUE_TYPE(blink::features::kForceWebContentsDarkMode)},
+#else
FEATURE_WITH_PARAMS_VALUE_TYPE(blink::features::kForceWebContentsDarkMode,
kForceDarkVariations,
"ForceDarkVariations")},
-#endif // !OS_CHROMEOS
+#endif // OS_CHROMEOS
#if defined(OS_ANDROID)
{"enable-android-dark-search", flag_descriptions::kAndroidDarkSearchName,
flag_descriptions::kAndroidDarkSearchDescription, kOsAndroid,
@@ -5374,6 +5375,10 @@
{"enable-hostname-setting", flag_descriptions::kEnableHostnameSettingName,
flag_descriptions::kEnableHostnameSettingDescription, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::features::kEnableHostnameSetting)},
+
+ {"webui-dark-mode", flag_descriptions::kWebuiDarkModeName,
+ flag_descriptions::kWebuiDarkModeDescription, kOsCrOS,
+ FEATURE_VALUE_TYPE(features::kWebUIDarkMode)},
#endif // OS_CHROMEOS
{"autofill-off-no-server-data",
