Navigation: Factoring state update during commit in RenderFrame
This CL aims to factor a function that does pre commit update
of the navigation state in the RenderFrameImpl. Preparatory work for
https://chromium-review.googlesource.com/c/chromium/src/+/789857
BUG=784904
Change-Id: I9d131ef23df6c48b3cb35e2136d52c7a235965d2
Reviewed-on: https://chromium-review.googlesource.com/854133
Commit-Queue: Arthur Hemery <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#528706}diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index c11796d6..ce667b31 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -955,13 +955,6 @@
bool IsLocalRoot() const;
const RenderFrameImpl* GetLocalRoot() const;
- // Builds and sends DidCommitProvisionalLoad to the host.
- void SendDidCommitProvisionalLoad(
- blink::WebLocalFrame* frame,
- blink::WebHistoryCommitType commit_type,
- service_manager::mojom::InterfaceProviderRequest
- remote_interface_provider_request);
-
// Swaps the current frame into the frame tree, replacing the
// RenderFrameProxy it is associated with. Return value indicates whether
// the swap operation succeeded. This should only be used for provisional
@@ -1288,6 +1281,11 @@
void NotifyObserversOfNavigationCommit(bool is_new_navigation,
bool is_same_document);
+ // Updates the internal state following a navigation commit. This should be
+ // called before notifying the FrameHost of the commit.
+ void UpdateStateForCommit(const blink::WebHistoryItem& item,
+ blink::WebHistoryCommitType commit_type);
+
// Stores the WebLocalFrame we are associated with. This is null from the
// constructor until BindToFrame() is called, and it is null after
// FrameDetached() is called until destruction (which is asynchronous in the
