Google Git
Sign in
chromium / chromium / src.git / c243d714a548c079e1ef53ef62e1912bb4af625a
commitc243d714a548c079e1ef53ef62e1912bb4af625a[log] [tgz]
authorErik Anderson <[email protected]>Fri Jul 30 00:13:41 2021
committerChromium LUCI CQ <[email protected]>Fri Jul 30 00:13:41 2021
treed9df92755c0093a2f071c4b9b87a2b76615161b8
parent5c9c70ccac80909bcde3f1a9ab887c582305db2f [diff]
Revert "DnsConfigServiceWin::ConfigReader: Add cap on the number of retries"

This reverts commit 58137339ca8bef42bbdc07a01078d294ef9f5a23.

Reason for revert: the new SerialWorkerTest tests are showing flakiness as reported in bug 1234162.

Original change's description:
> DnsConfigServiceWin::ConfigReader: Add cap on the number of retries
>
> Add retry logic to SerialWorker and remove the existing retry logic in
> DnsConfigServiceWin::ConfigReader in favor of using the SerialWorker
> functionality with new logic to cap the number of retries.
>
> The DnsConfigServiceWin::ConfigReader retry logic was added in case of
> race conditions between getting registry change notifications and
> reading out DNS configuration from the OS.
>
> When in an offline state, no DNS servers are available. Prior to this
> change, the ConfigReader wakes up every 5 seconds to try again which has
> a negative impact on performance and battery life since the CPU can't
> stay in a low power state. After this change, we will retry 3 times with
> a base delay of 5 seconds for the first retry and a 2x exponential
> backoff for each additional retry.
>
> If a state change is seen (e.g. via the registry watchers and hosts file
> watcher), the retry count is reset.
>
> Bug: 1225838
> Change-Id: Idf801b1e2934649021df08dbfe9569fd81e7ae84
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3036528
> Commit-Queue: Erik Anderson <[email protected]>
> Reviewed-by: Eric Orth <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#905004}

Bug: 1225838
Change-Id: Ia6f593e6965039ab173110ae20e4024ad3cd169b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3058803
Commit-Queue: Erik Anderson <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Erik Anderson <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Eric Orth <[email protected]>
Cr-Commit-Position: refs/heads/master@{#906930}
9 files changed
tree: d9df92755c0093a2f071c4b9b87a2b76615161b8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.