Add smart suggestion for large downloads flag
This CL adds the flag for handling smart suggestion for large downloads
Bug: 1118207
Change-Id: I695757bef4119d97fc594d08945406a14a36723c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368154
Commit-Queue: Hung Vu <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Hesen Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#800737}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 70dcd8e..b8e032a0 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -6338,6 +6338,14 @@
FEATURE_VALUE_TYPE(blink::features::kCrOSAutoSelect)},
#endif // defined(OS_CHROMEOS)
+#if defined(OS_ANDROID)
+ {"smart-suggestion-for-large-downloads",
+ flag_descriptions::kSmartSuggestionForLargeDownloadsName,
+ flag_descriptions::kSmartSuggestionForLargeDownloadsDescription,
+ kOsAndroid,
+ FEATURE_VALUE_TYPE(download::features::kSmartSuggestionForLargeDownloads)},
+#endif // defined(OS_ANDROID)
+
#if BUILDFLAG(ENABLE_AV1_DECODER)
{"enable-avif", flag_descriptions::kEnableAVIFName,
flag_descriptions::kEnableAVIFDescription, kOsDesktop,
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index 44690a57..6efe130 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -4139,6 +4139,11 @@
"expiry_milestone": 88
},
{
+ "name": "smart-suggestion-for-large-downloads",
+ "owners": [ "vuhung", "shaktisahu"],
+ "expiry_milestone": 89
+ },
+ {
"name": "smart-text-selection",
"owners": [ "djacobo", "linben" ],
"expiry_milestone": 76
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 6556aa9e..b5fefdc 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -3096,6 +3096,11 @@
"Security mode that enables site isolation for sites based on "
"password-oriented heuristics, such as a user typing in a password.";
+const char kSmartSuggestionForLargeDownloadsName[] =
+ "Smart suggestion for large downloads";
+const char kSmartSuggestionForLargeDownloadsDescription[] =
+ "Smart suggestion that offers download locations for large files.";
+
const char kStartSurfaceAndroidName[] = "Start Surface";
const char kStartSurfaceAndroidDescription[] =
"Enable showing the start surface when launching Chrome via the "
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index 2c032b10..aa34145 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -1785,6 +1785,9 @@
extern const char kSiteIsolationForPasswordSitesName[];
extern const char kSiteIsolationForPasswordSitesDescription[];
+extern const char kSmartSuggestionForLargeDownloadsName[];
+extern const char kSmartSuggestionForLargeDownloadsDescription[];
+
extern const char kStartSurfaceAndroidName[];
extern const char kStartSurfaceAndroidDescription[];
