Change meaning of "IsLoadingToDifferentDocument" in WebContents to only
apply to loads in the main frame.
The distinction between "IsLoading" and "IsLoadingToDifferentDocument"
appears to only be relevant in UI contexts (e.g. TabRendererData, which
controls whether to show the throbber in the tabstrip on desktop
Chrome). I think the distinction only makes sense in the context of the
main frame and a load in a subframe should always be lumped in with
non-top-level document loads. For example, on Android it's sometimes
used to conditionally call ToolbarLayout.onNavigatedToDifferentPage(),
which from other callsites definitely appears to only care about main
frame navigations.
Making this change means the throbber won't flicker when content is
loaded in an iframe right after the main frame finishes loading, which
happens a lot (see bug).
With this change, we can probably remove the timer added in
896032108c97ec8e014f which attempts to smooth out favicon/throbber
flickering.
Bug: 734104
Change-Id: Ie14b1c54956479021fd9aa6c4c8aa690be52f193
Reviewed-on: https://chromium-review.googlesource.com/569060
Reviewed-by: Pavel Feldman <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#486854}diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index b85d291..e967a2f 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4812,7 +4812,8 @@
void WebContentsImpl::DidStartLoading(FrameTreeNode* frame_tree_node,
bool to_different_document) {
- LoadingStateChanged(to_different_document, false, nullptr);
+ LoadingStateChanged(frame_tree_node->IsMainFrame() && to_different_document,
+ false, nullptr);
// Notify accessibility that the user is navigating away from the
// current document.
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 9c837588..569ae3d 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -1361,7 +1361,7 @@
// Data for loading state ----------------------------------------------------
// Indicates whether the current load is to a different document. Only valid
- // if is_loading_ is true.
+ // if |is_loading_| is true and only tracks loads in the main frame.
bool is_load_to_different_document_;
// Indicates if the tab is considered crashed.
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 378075df..31e4ebf 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -3245,6 +3245,58 @@
EXPECT_FALSE(observer.is_loading());
}
+// Tests that WebContentsImpl::IsLoadingToDifferentDocument only reports main
+// frame loads. Browser-initiated navigation of subframes is only possible in
+// --site-per-process mode within unit tests.
+TEST_F(WebContentsImplTestWithSiteIsolation, IsLoadingToDifferentDocument) {
+ const GURL main_url("http://www.chromium.org");
+ TestRenderFrameHost* orig_rfh = main_test_rfh();
+
+ // Navigate the main RenderFrame, simulate the DidStartLoading, and commit.
+ // The frame should still be loading.
+ controller().LoadURL(main_url, Referrer(), ui::PAGE_TRANSITION_TYPED,
+ std::string());
+ int entry_id = controller().GetPendingEntry()->GetUniqueID();
+
+ // PlzNavigate: the RenderFrameHost does not expect to receive
+ // DidStartLoading IPCs for navigations to different documents.
+ if (!IsBrowserSideNavigationEnabled()) {
+ orig_rfh->OnMessageReceived(
+ FrameHostMsg_DidStartLoading(orig_rfh->GetRoutingID(), false));
+ }
+ main_test_rfh()->PrepareForCommit();
+ contents()->TestDidNavigate(orig_rfh, entry_id, true, main_url,
+ ui::PAGE_TRANSITION_TYPED);
+ EXPECT_FALSE(contents()->CrossProcessNavigationPending());
+ EXPECT_EQ(orig_rfh, main_test_rfh());
+ EXPECT_TRUE(contents()->IsLoading());
+ EXPECT_TRUE(contents()->IsLoadingToDifferentDocument());
+
+ // Send the DidStopLoading for the main frame and ensure it isn't loading
+ // anymore.
+ orig_rfh->OnMessageReceived(
+ FrameHostMsg_DidStopLoading(orig_rfh->GetRoutingID()));
+ EXPECT_FALSE(contents()->IsLoading());
+ EXPECT_FALSE(contents()->IsLoadingToDifferentDocument());
+
+ // Create a child frame to navigate.
+ TestRenderFrameHost* subframe = orig_rfh->AppendChild("subframe");
+
+ // Navigate the child frame to about:blank, make sure the web contents is
+ // marked as "loading" but not "loading to different document".
+ if (!IsBrowserSideNavigationEnabled()) {
+ subframe->OnMessageReceived(
+ FrameHostMsg_DidStartLoading(subframe->GetRoutingID(), true));
+ }
+ subframe->SendNavigateWithTransition(0, false, GURL("about:blank"),
+ ui::PAGE_TRANSITION_AUTO_SUBFRAME);
+ EXPECT_TRUE(contents()->IsLoading());
+ EXPECT_FALSE(contents()->IsLoadingToDifferentDocument());
+ subframe->OnMessageReceived(
+ FrameHostMsg_DidStopLoading(subframe->GetRoutingID()));
+ EXPECT_FALSE(contents()->IsLoading());
+}
+
// Ensure that WebContentsImpl does not stop loading too early when there still
// is a pending renderer. This can happen if a same-process non user-initiated
// navigation completes while there is an ongoing cross-process navigation.
