| commit | c4fefb0436dabbd7b1b1e58af1962477380eaa36 | [log] [tgz] |
|---|---|---|
| author | Karan Bhatia <[email protected]> | Tue Jun 25 00:12:48 2019 |
| committer | Commit Bot <[email protected]> | Tue Jun 25 00:12:48 2019 |
| tree | 94a56f58b63725f9b637c9c658ff028b8ce519a4 | |
| parent | c49c225f49dc6a11ea75aa89c94282c411f81b06 [diff] [blame] |
DisplayInfoProvider: Remove dependency on extensions embedder. DisplayInfoProvider::Create is declared at the extensions layer but not defined. The expectation is that the extensions embedder will define it. However this is not ideal since any target depending on just extensions gets an undefined function linking error. Correct this by introducing ExtensionsAPIClient::CreateDisplayInfoProvider and introducing appropriate embedder implementations. BUG=976556 Change-Id: I1a9d51ef90d2837ea4bc18cb6df7a629609d7d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666446 Commit-Queue: Karan Bhatia <[email protected]> Reviewed-by: Steven Bennetts <[email protected]> Reviewed-by: Devlin <[email protected]> Reviewed-by: Luke Halliwell <[email protected]> Cr-Commit-Position: refs/heads/master@{#671861}
diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn index 442f7ee..9ee32ea 100644 --- a/chrome/browser/extensions/BUILD.gn +++ b/chrome/browser/extensions/BUILD.gn
@@ -685,6 +685,7 @@ "suspicious_extension_bubble_delegate.h", "sync_bundle.cc", "sync_bundle.h", + "system_display/display_info_provider.h", "system_display/display_info_provider_chromeos.cc", "system_display/display_info_provider_chromeos.h", "system_display/display_info_provider_mac.cc",