Cleanup WebFrameClient::DownloadURL
* Call it directly from DecidePolicyForNavigation() whenever needed, rather
than sometimes deferring to FrameLoader.
* Remove unused suggested_filename param
* Update unit tests to ensure DecidePolicyForNavigation() always returns the
same subset of WebNavigationPolicy values whether in unit tests or a real
environment. DCHECK this in FrameLoader
Change-Id: Ifd9a96c094eacdf090676a522ee858bf0b9ce7b3
Reviewed-on: https://chromium-review.googlesource.com/944917
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541291}diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 5bb6141..8ae31282 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -624,8 +624,7 @@
const blink::WebString& source_name,
unsigned source_line,
const blink::WebString& stack_trace) override;
- void DownloadURL(const blink::WebURLRequest& request,
- const blink::WebString& suggested_name) override;
+ void DownloadURL(const blink::WebURLRequest& request) override;
void LoadErrorPage(int reason) override;
blink::WebNavigationPolicy DecidePolicyForNavigation(
const NavigationPolicyInfo& info) override;
