Enable QuicConnectionId variable length flags
This change reenables the QuicConnectionId variable length flags
(which makes QuicConnectionId be represented in memory in network
byte order) and fixes chromium-specific behavior that used to rely
on the connection IDs being 64 bits.
Bug: b/123008920
Change-Id: I9497c516a8612be3c0aaddd152825f559a9086f3
Reviewed-on: https://chromium-review.googlesource.com/c/1418632
Commit-Queue: David Schinazi <[email protected]>
Auto-Submit: David Schinazi <[email protected]>
Reviewed-by: Steve Anton <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#625530}diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index ada58429..aac7381e7 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -49,6 +49,7 @@
#include "net/third_party/quic/core/crypto/quic_decrypter.h"
#include "net/third_party/quic/core/crypto/quic_encrypter.h"
#include "net/third_party/quic/core/http/quic_client_promised_info.h"
+#include "net/third_party/quic/core/quic_utils.h"
#include "net/third_party/quic/platform/api/quic_test.h"
#include "net/third_party/quic/test_tools/mock_clock.h"
#include "net/third_party/quic/test_tools/mock_random.h"
@@ -226,18 +227,20 @@
version_(version),
client_headers_include_h2_stream_dependency_(
client_headers_include_h2_stream_dependency),
- client_maker_(version_,
- quic::EmptyQuicConnectionId(),
- &clock_,
- kDefaultServerHostName,
- quic::Perspective::IS_CLIENT,
- client_headers_include_h2_stream_dependency_),
- server_maker_(version_,
- quic::EmptyQuicConnectionId(),
- &clock_,
- kDefaultServerHostName,
- quic::Perspective::IS_SERVER,
- false),
+ client_maker_(
+ version_,
+ quic::QuicUtils::CreateRandomConnectionId(&random_generator_),
+ &clock_,
+ kDefaultServerHostName,
+ quic::Perspective::IS_CLIENT,
+ client_headers_include_h2_stream_dependency_),
+ server_maker_(
+ version_,
+ quic::QuicUtils::CreateRandomConnectionId(&random_generator_),
+ &clock_,
+ kDefaultServerHostName,
+ quic::Perspective::IS_SERVER,
+ false),
cert_verifier_(std::make_unique<MockCertVerifier>()),
cert_transparency_verifier_(std::make_unique<DoNothingCTVerifier>()),
scoped_mock_network_change_notifier_(nullptr),
