[Password change] Add variation for the password change flag
The new variation will allow showing credential leaked dialog after
every form submission (helpful for testing).
Bug: 1086111
Change-Id: Ifdc553e98ac923f2b762621c25ea0becc35134ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228619
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Friedrich [CET] <[email protected]>
Commit-Queue: Milica Selakovic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#775152}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index a9c0e2b..d212cfb1 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1932,6 +1932,22 @@
switches::kEnableExperimentalCookieFeatures, ""},
};
+#if defined(OS_ANDROID)
+// The variations of --password-change-support.
+const FeatureEntry::FeatureParam
+ kPasswordChangeVariationWithForcedDialogAfterEverySuccessfulSubmission[] = {
+ {password_manager::features::
+ kPasswordChangeWithForcedDialogAfterEverySuccessfulSubmission,
+ "true"}};
+
+const FeatureEntry::FeatureVariation kPasswordChangeFeatureVariations[] = {
+ {"Force dialog after every successful form submission.",
+ kPasswordChangeVariationWithForcedDialogAfterEverySuccessfulSubmission,
+ base::size(
+ kPasswordChangeVariationWithForcedDialogAfterEverySuccessfulSubmission),
+ nullptr}};
+#endif // defined(OS_ANDROID)
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name.
@@ -5443,11 +5459,13 @@
FEATURE_VALUE_TYPE(chromeos::features::kAmbientModeFeature)},
#endif // defined(OS_CHROMEOS)
- {"password-change-support", flag_descriptions::kPasswordChangeName,
- flag_descriptions::kPasswordChangeDescription, kOsAll,
- FEATURE_VALUE_TYPE(password_manager::features::kPasswordChange)},
-
#if defined(OS_ANDROID)
+ {"password-change-support", flag_descriptions::kPasswordChangeName,
+ flag_descriptions::kPasswordChangeDescription, kOsAndroid,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(password_manager::features::kPasswordChange,
+ kPasswordChangeFeatureVariations,
+ "PasswordChangeFeatureVariations.")},
+
{"context-menu-performance-info",
flag_descriptions::kContextMenuPerformanceInfoName,
flag_descriptions::kContextMenuPerformanceInfoDescription, kOsAndroid,
