Google Git
Sign in
chromium / chromium / src.git / ca25070f30bb98b0e33b6d0d0ab54b3c90977eef
commitca25070f30bb98b0e33b6d0d0ab54b3c90977eef[log] [tgz]
authorDave Tapuska <[email protected]>Thu Jan 07 17:40:55 2021
committerChromium LUCI CQ <[email protected]>Thu Jan 07 17:40:55 2021
treeb924a5299b22cded619f291e3a1a9f13415d0c97
parent7f22ba8212c4cbe91f8c441376ca48f1de672d57 [diff]
Convert UnfreezableFrameMsg_Unload to mojo.

Move Unload to be a message on the FrameNavigationController.
Messages on an associated mojo interface are dispatched against
the main task runner so they aren't really frozen. So this method can
move to be just a normal associated interface.

The result of unload is dispatched to the AgentSchedulingGroupHost
because we need to return the result and the FrameNavigationController
is disconnected when RenderFrameImpl is destroyed so any callback
on that won't be called.

Other approaches were considered but deemed too difficult:
1) We can't simply Unbind() the FrameNavigationControl
AssociatedReceiver since that doesn't work if there are already
pending reply callbacks.
2) We can't use a unique_ptr to own the FrameNavigationControl
AssociatedReceiver, since the AssociatedReceiver also needs to be
paused.
3) Deferring deletion of the RenderFrameImpl would be undesirable
(as the associated WebLocalFrame is already gone)
4) Reporting it through an interface passed to the Unload() method
would add a non-trivial amount of complexity

BUG=993189

Change-Id: I4f8a29c09b34596e2d5d8d2595a04306ccb1e569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580002
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#841094}
28 files changed
tree: b924a5299b22cded619f291e3a1a9f13415d0c97
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.