Fix scheme check in SiteInstance::IsSameWebSite for nested URLs.
BUG=726370
Review-Url: https://codereview.chromium.org/2913443002
Cr-Commit-Position: refs/heads/master@{#476164}
diff --git a/content/browser/site_instance_impl.cc b/content/browser/site_instance_impl.cc
index d8b0d28..0e47c20 100644
--- a/content/browser/site_instance_impl.cc
+++ b/content/browser/site_instance_impl.cc
@@ -318,19 +318,11 @@
return src_origin == dest_origin;
// If the schemes differ, they aren't part of the same site.
- //
- // Note that this happens after the isolated origin check, since blob or
- // filesystem URLs will fail this check even though they might have the
- // same origin.
- //
- // TODO(alexmos): This check seems broken for nested URLs involving
- // non-isolated origins too. See https://crbug.com/726370.
- if (src_url.scheme() != dest_url.scheme())
+ if (src_origin.scheme() != dest_origin.scheme())
return false;
return net::registry_controlled_domains::SameDomainOrHost(
- src_url,
- dest_url,
+ src_origin, dest_origin,
net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
}
