[conversions] Add about flags entries for API and debug mode
Adds about flag entries for enabling the API as well as the debug mode
version. Exposed for developer testing.
Bug: 1082421
Change-Id: Ib68277248ba35c563932d7d296cce6b74e77ad66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198645
Commit-Queue: John Delaney <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#768515}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index cc6ea4f..02361b3 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -5585,6 +5585,15 @@
FEATURE_VALUE_TYPE(
autofill::features::kAutofillEnableCardNicknameManagement)},
+ {"conversion-measurement-api",
+ flag_descriptions::kConversionMeasurementApiName,
+ flag_descriptions::kConversionMeasurementApiDescription, kOsAll,
+ FEATURE_VALUE_TYPE(features::kConversionMeasurement)},
+ {"conversion-measurement-debug-mode",
+ flag_descriptions::kConversionMeasurementDebugModeName,
+ flag_descriptions::kConversionMeasurementDebugModeDescription, kOsAll,
+ SINGLE_VALUE_TYPE(switches::kConversionsDebugMode)},
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index d7a5af4..f56c5762 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -611,6 +611,16 @@
"expiry_milestone": 86
},
{
+ "name": "conversion-measurement-api",
+ "owners": [ "//content/browser/conversions/OWNERS" ],
+ "expiry_milestone": 87
+ },
+ {
+ "name": "conversion-measurement-debug-mode",
+ "owners": [ "//content/browser/conversions/OWNERS" ],
+ "expiry_milestone": 87
+ },
+ {
"name": "cookie-deprecation-messages",
"owners": [ "bingler", "chlily", "aarontag" ],
"expiry_milestone": 90
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index e996fe5e..91ead99 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -75,6 +75,17 @@
const char kConditionalTabStripAndroidDescription[] =
"Allows users to access conditional tab strip.";
+const char kConversionMeasurementApiName[] = "Conversion Measurement API";
+const char kConversionMeasurementApiDescription[] =
+ "Enables usage of the Conversion Measurement API.";
+
+const char kConversionMeasurementDebugModeName[] =
+ "Conversion Measurement Debug Mode";
+const char kConversionMeasurementDebugModeDescription[] =
+ "Enables debug mode for the Conversion Measurement API. This removes all "
+ "reporting delays and noise. Only works if the Conversion Measurement API "
+ "is already enabled.";
+
const char kEnableClipboardProviderImageSuggestionsName[] =
"Omnibox clipboard image search suggestions";
const char kEnableClipboardProviderImageSuggestionsDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index 41bf756f..cede3145 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -76,6 +76,12 @@
extern const char kAllowSyncXHRInPageDismissalName[];
extern const char kAllowSyncXHRInPageDismissalDescription[];
+extern const char kConversionMeasurementApiName[];
+extern const char kConversionMeasurementApiDescription[];
+
+extern const char kConversionMeasurementDebugModeName[];
+extern const char kConversionMeasurementDebugModeDescription[];
+
extern const char kEnableClipboardProviderImageSuggestionsName[];
extern const char kEnableClipboardProviderImageSuggestionsDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index eaedc42..1cb509a 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -40655,6 +40655,7 @@
<int value="656864700" label="FillOnAccountSelectHttp:disabled"/>
<int value="659086147" label="OverlayScrollbarFlashWhenMouseEnter:enabled"/>
<int value="661020875" label="AutofillSaveCardShowNoThanks:disabled"/>
+ <int value="662331859" label="ConversionMeasurement:enabled"/>
<int value="663027937" label="NewTabPageCustomLinks:enabled"/>
<int value="663069508" label="TabToGTSAnimation:enabled"/>
<int value="663294302" label="ForceUseAPDownloadProtection:disabled"/>
@@ -40860,6 +40861,7 @@
<int value="913138924" label="RecurrentInterstitialFeature:disabled"/>
<int value="913855453" label="VirtualKeyboardFloatingResizable:disabled"/>
<int value="916316159" label="disable-new-app-list-mixer"/>
+ <int value="917561046" label="ConversionMeasurement:disabled"/>
<int value="918046854" label="NtlmV2Enabled:disabled"/>
<int value="921536672" label="OfflinePagesDescriptiveFailStatus:enabled"/>
<int value="921561616" label="WebAssemblyTiering:disabled"/>
@@ -41791,6 +41793,7 @@
label="AutofillEnableFixedPaymentsBubbleLogging:enabled"/>
<int value="1964816410" label="AndroidPayIntegrationV2:enabled"/>
<int value="1965055310" label="SyncSetupFriendlySettings:enabled"/>
+ <int value="1965534355" label="conversions-debug-mode"/>
<int value="1965976546" label="NewOverviewAnimations:disabled"/>
<int value="1966730288" label="disable-threaded-compositing"/>
<int value="1968199744" label="PrintJobManagementApp:disabled"/>
