| commit | cd439782d47215b6ccd81f7740558cf63d0f76c1 | [log] [tgz] |
|---|---|---|
| author | Victor Costan <[email protected]> | Thu Aug 30 07:27:57 2018 |
| committer | Commit Bot <[email protected]> | Thu Aug 30 07:27:57 2018 |
| tree | 32c4cf44f93453a8d2578294f817f6ed3ca5dbdd | |
| parent | 9f74500e5499b2b85040257bced50c40278fe69f [diff] |
net: Make net::DrainableIOBuffer constructors take scoped_refptr. The net::DrainableIOBuffer constructors currently take in a net::IOBuffer base as a raw pointer, then assign it to a scoped_refptr<net::IOBuffer> member, thus taking a reference. This CL turns the raw pointer parameter into a scoped_refptr, and uses std::move() during the member assignment. So, the reference-increment operation is pushed from the constructors to the construction callsites. No new increments are introduced. The CL also modifies the DrainableIOBuffer construction sites, using std::move() where possible to remove reference increments. Bug: 479898 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I95cd0973d5e25c2565ddecfa0e06a3fc15e1f7b9 Reviewed-on: https://chromium-review.googlesource.com/1188955 Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Matt Menke <[email protected]> Reviewed-by: Lei Zhang <[email protected]> Reviewed-by: Dmitry Gozman <[email protected]> Reviewed-by: Nicolas Zea <[email protected]> Reviewed-by: Cait Phillips <[email protected]> Reviewed-by: Jamie Walch <[email protected]> Cr-Commit-Position: refs/heads/master@{#587471}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .