| commit | ce66b9fa9f0e1428c0f05f6c7091d4185c681937 | [log] [tgz] |
|---|---|---|
| author | Eric Aleshire <[email protected]> | Fri Feb 08 08:00:31 2019 |
| committer | Commit Bot <[email protected]> | Fri Feb 08 08:00:31 2019 |
| tree | 86a422540b8d6900d2b2df6b559b93f76096f552 | |
| parent | a68807e1cbb03365f55c9d88eaa8924814974a17 [diff] [blame] |
Convert test_running.py to use Python logging, and add more logs. The commit https://chromium-review.googlesource.com/c/chromium/src/+/1448684 didn't seem to solve the issue where sometimes passing tests will time out - EG tests that passed seem to hang before even reaching the "Waiting for test process to terminate." line, and GTest tests that get SIGTERM'd properly terminate but don't seem to return before hard timeout. This changeset migrates to Python logging to allow for timestamping of logging, and adds additional logging. Combined this should help provide a closer picture of what's going on with this issue. Bug: 898549 Change-Id: Ibc5963f820541a23c939eff5562b672d6200c0b1 Reviewed-on: https://chromium-review.googlesource.com/c/1459322 Commit-Queue: ericale <[email protected]> Reviewed-by: Sergey Berezin <[email protected]> Cr-Commit-Position: refs/heads/master@{#630240}
diff --git a/ios/build/bots/scripts/test_runner_test.py b/ios/build/bots/scripts/test_runner_test.py index 1da6292..dce3dc8 100755 --- a/ios/build/bots/scripts/test_runner_test.py +++ b/ios/build/bots/scripts/test_runner_test.py
@@ -7,6 +7,7 @@ import collections import glob +import logging import os import subprocess import unittest @@ -605,4 +606,6 @@ if __name__ == '__main__': + logging.basicConfig(format='[%(asctime)s:%(levelname)s] %(message)s', + level=logging.DEBUG, datefmt='%I:%M:%S') unittest.main()