ash: Fix variable names and setters in ShelfLayoutManager and tests
Calls to set shelf state should go through Shelf, not ShelfLayoutManager.
* Move all calls to SetAutoHideBehavior() and SetAlignment() to Shelf instead
of ShelfLayoutManager.
* Add Shelf::GetVisibilityState() and Shelf::GetAutoHideState() and prefer
using them to accessing ShelfLayoutManager directly.
* Remove ShelfLayoutManager::GetAutoHideBehavior().
* Rename variables mis-named "shelf" to shelf_widget, shelf_layout_manager, etc.
so they match their actual types.
No functional changes.
BUG=615502
TEST=ash_unittests
Review-Url: https://codereview.chromium.org/2017413002
Cr-Commit-Position: refs/heads/master@{#397214}
21 files changed
