Google Git
Sign in
chromium / chromium / src.git / d16e059d75a005cba39f00e9495b3dffa8b69376
commitd16e059d75a005cba39f00e9495b3dffa8b69376[log] [tgz]
authorAdrienne Walker <[email protected]>Wed Nov 27 01:25:52 2019
committerCommit Bot <[email protected]>Wed Nov 27 01:25:52 2019
treed7f178f6acc76536e48d15fa1ba209df463fcf75
parentcf74abc8ebebe47acdec695b3455010d227e27c7 [diff]
storage: have idb talk to BlobStorageContext via mojo

This changes the "reading blobs" part of IndexedDB to use the
storage.mojom.BlobStorageContext mojo interface for creating
file-backed blobs.

It uses this mojo interface from the idb task runner, owned
by the IndexedDBDispatcherHost.  CreateAllBlobs no longer can
fail (as all callsites already check that the dispatcher host
exists), which cleans up some code as well.

Instead of having files, they use the BlobDataItem(Reader) types
to provide the file information to the blob system.  This also
frees IndexedDB in the future to back these blobs in any way that
it chooses, not necessarily via files.

Because ShareableFileReference is used by both the browser and
in IndexedDB, a new way of tracking live file references is used.
IndexedDBDispatcherHost has a map of file paths to active
BlobDataItemReaders, and calls the release callback when all
the mojo pipes to that reader have been closed.  This lets
ShareableFileReference continue to live on the IO thread for
the browser use cases and will let IndexedDB more easily move
to the storage service without this dependency.

The followup to this cl is to change IndexedDBBlobInfo to use
blob remotes instead of BlobDataHandle and to return clones of
those remotes rather than using BlobImpl::Create directly.

Bug: 1022214
Change-Id: Ia1abc519fd5877aaf2313e45d0daea4a38c52d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902474
Commit-Queue: enne <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#719453}
21 files changed
tree: d7f178f6acc76536e48d15fa1ba209df463fcf75
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .