Revert "Reland "Remove influence of group name on NTPPopularSites studies""
This reverts commit ffc93ab8afc61f4bfea18b81c8b8cc4290dc238a.
Reason for revert: This change broke It broke components_unittests on multiple bots. See crbug.com/808260.
Original change's description:
> Reland "Remove influence of group name on NTPPopularSites studies"
>
> This is a reland of 1a544c783e00bf6adb51be7590fee71f5c4a4185.
>
> Original change's description:
> > Remove influence of group name on NTPPopularSites studies
> >
> > Recently, a misnamed study (see deleted test config) caused the feature
> > to fall back to the default popular sites. This isn't a big problem but
> > when it was finally named correctly, the names of the groups disabled
> > all popular sites.
> >
> > Popular sites should not be so easy to disable. Therefore, remove the
> > group name condition.
> >
> > A forced cmd line flag should cover all possible cases and make the
> > intention very clear. This is already in place and remains untouched.
> >
> > Bug: 794329
> > Change-Id: I71458d41de6d0e0d5f0d8fcde1b636b0fe18618c
> > Reviewed-on: https://chromium-review.googlesource.com/827072
> > Commit-Queue: Friedrich Horschig <[email protected]>
> > Reviewed-by: Gayane Petrosyan <[email protected]>
> > Reviewed-by: Marc Treib <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#528301}
>
> Bug: 794329
> Change-Id: I0c391668095cd66be012f0d1d483ff0970cbb018
> Reviewed-on: https://chromium-review.googlesource.com/888560
> Reviewed-by: Gayane Petrosyan <[email protected]>
> Commit-Queue: Friedrich Horschig <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#533690}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I2ca9733fc9fbb2efa667e44af25ab204f24c2efd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 794329, 808260
Reviewed-on: https://chromium-review.googlesource.com/898494
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#533879}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 66e9c4db..104e7b0 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -62,6 +62,7 @@
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
#include "components/ntp_tiles/constants.h"
+#include "components/ntp_tiles/switches.h"
#include "components/offline_pages/core/offline_page_feature.h"
#include "components/omnibox/browser/omnibox_field_trial.h"
#include "components/omnibox/browser/omnibox_switches.h"
@@ -2359,6 +2360,12 @@
"disallowFetchForDocWrittenScriptsInMainFrame=true",
switches::kBlinkSettings,
"disallowFetchForDocWrittenScriptsInMainFrame=false")},
+#if defined(OS_ANDROID)
+ {"enable-ntp-popular-sites", flag_descriptions::kNtpPopularSitesName,
+ flag_descriptions::kNtpPopularSitesDescription, kOsAndroid,
+ ENABLE_DISABLE_VALUE_TYPE(ntp_tiles::switches::kEnableNTPPopularSites,
+ ntp_tiles::switches::kDisableNTPPopularSites)},
+#endif // OS_ANDROID
#if defined(OS_WIN)
{"trace-export-events-to-etw",
flag_descriptions::kTraceExportEventsToEtwName,
