Disallow new inclusions of SigninManager/ProfileOAuth2TokenService
Per https://groups.google.com/a/chromium.org/d/msg/chromium-dev/dgFLuxqZt1o/iEqkyoQQBwAJ,
prospective clients of these API surfaces should instead be using
IdentityManager. Contact identity-service-dev@ with any questions.
Where possible, inclusions are disallowed with "-". Where there are
existing usages that still need to be converted, inclusions are instead
disallowed with "!".
Note that the CQ will effectively not report any meaningful results for
this CL, as its usage of checkdeps doesn't run in directories where only
DEPS files have been changed. Here is the result of a local full run
of checkdeps.py:
blundell:src(forbid_new_inclusions) $ ./buildtools/checkdeps/checkdeps.py
Using base directory: /usr/local/google/home/blundell/clankium/src
Checking: /usr/local/google/home/blundell/clankium/src
SUCCESS
Finally, this CL also just strips out dependencies entirely that I
determined to be stale.
This CL is a reland of https://chromium-review.googlesource.com/c/1374986
with a minor fix for a checkdeps error in PS2.
Note: Adding NOTRY=true as the only bot that's failing is the iOS
simulator bot, which is having timeout issues that are totally unrelated
to this CL.
[email protected]
NOTRY=true
Bug: 883318, 883330
Change-Id: I40971fdbfef00b4416ff7bfec875514706c0e26f
Reviewed-on: https://chromium-review.googlesource.com/c/1382092
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#617509}diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS
index d3d9eb9..a003b68 100644
--- a/chrome/browser/DEPS
+++ b/chrome/browser/DEPS
@@ -21,6 +21,13 @@
"+chrome_elf/dll_hash",
"+chromeos",
"+components",
+ # Use identity_manager.h instead of the below files;
+ # see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/dgFLuxqZt1o/iEqkyoQQBwAJ for help and info.
+ "!components/signin/core/browser/fake_profile_oauth2_token_service.h",
+ "!components/signin/core/browser/profile_oauth2_token_service.h",
+ "!components/signin/core/browser/fake_signin_manager.h",
+ "!components/signin/core/browser/signin_manager.h",
+ "!components/signin/core/browser/signin_manager_base.h",
"+content/public/browser",
"+content/public/common",
"+courgette",
