commit d90695c943f92eac547ee04ad0913f6e316258de
author rkaplow <rkaplow@chromium.org> Wed Mar 25 22:12:41 2015
committer Commit bot <commit-bot@chromium.org> Wed Mar 25 22:13:39 2015
tree 8e90300f882eb071ca6d3ced2d0e65d054debdbb
parent 5e26b8a570bb183c6a3686555fc61e545a3868c2

Delete the ClientSocketPoolHistograms class.

This class write the
Net.SocketIdleTimeBeforeNextUse_ReusedSocket
Net.SocketIdleTimeBeforeNextUse_UnusedSocket
Net.SocketInitErrorCodes
Net.SocketRequestTime
Net.SocketType
histograms.

This histograms are all unowned, and have a large cumulative load on user bandwidth and internal google servers.
Are these histograms used at all? It appears they have not been used for some time (based on lack of ownership)

BUG=469288

Review URL: https://codereview.chromium.org/1027693004

Cr-Commit-Position: refs/heads/master@{#322244}

net/socket/client_socket_pool_base_unittest.cc

diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index c7cbda1..1606b42 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -28,7 +28,6 @@
 #include "net/http/http_response_headers.h"
 #include "net/socket/client_socket_factory.h"
 #include "net/socket/client_socket_handle.h"
-#include "net/socket/client_socket_pool_histograms.h"
 #include "net/socket/socket_test_util.h"
 #include "net/socket/ssl_client_socket.h"
 #include "net/socket/stream_socket.h"
@@ -482,12 +481,14 @@
   TestClientSocketPool(
       int max_sockets,
       int max_sockets_per_group,
-      ClientSocketPoolHistograms* histograms,
       base::TimeDelta unused_idle_socket_timeout,
       base::TimeDelta used_idle_socket_timeout,
       TestClientSocketPoolBase::ConnectJobFactory* connect_job_factory)
-      : base_(NULL, max_sockets, max_sockets_per_group, histograms,
-              unused_idle_socket_timeout, used_idle_socket_timeout,
+      : base_(NULL,
+              max_sockets,
+              max_sockets_per_group,
+              unused_idle_socket_timeout,
+              used_idle_socket_timeout,
               connect_job_factory) {}
 
   ~TestClientSocketPool() override {}
@@ -561,10 +562,6 @@
     return base_.ConnectionTimeout();
   }
 
-  ClientSocketPoolHistograms* histograms() const override {
-    return base_.histograms();
-  }
-
   const TestClientSocketPoolBase* base() const { return &base_; }
 
   int NumUnassignedConnectJobsInGroup(const std::string& group_name) const {
@@ -658,8 +655,7 @@
 class ClientSocketPoolBaseTest : public testing::Test {
  protected:
   ClientSocketPoolBaseTest()
-      : params_(new TestSocketParams(false /* ignore_limits */)),
-        histograms_("ClientSocketPoolTest") {
+      : params_(new TestSocketParams(false /* ignore_limits */)) {
     connect_backup_jobs_enabled_ =
         internal::ClientSocketPoolBaseHelper::connect_backup_jobs_enabled();
     internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(true);
@@ -691,7 +687,6 @@
                                                      &net_log_);
     pool_.reset(new TestClientSocketPool(max_sockets,
                                          max_sockets_per_group,
-                                         &histograms_,
                                          unused_idle_socket_timeout,
                                          used_idle_socket_timeout,
                                          connect_job_factory_));
@@ -732,7 +727,6 @@
   MockClientSocketFactory client_socket_factory_;
   TestConnectJobFactory* connect_job_factory_;
   scoped_refptr<TestSocketParams> params_;
-  ClientSocketPoolHistograms histograms_;
   scoped_ptr<TestClientSocketPool> pool_;
   ClientSocketPoolTest test_base_;
 };