Google Git
Sign in
chromium / chromium / src.git / d973a55b7929fccb10c59f594b8d5152a8fc1296
commitd973a55b7929fccb10c59f594b8d5152a8fc1296[log] [tgz]
authorW. James MacLean <[email protected]>Thu Nov 29 21:39:13 2018
committerCommit Bot <[email protected]>Thu Nov 29 21:39:13 2018
treea11e65c4bc4077cccd6b0e49099af1dd56fa125d
parent9ec5fbb46df56910a0e10832457b6dd901477236 [diff]
Implement OOPIF double-tap-zoom.

This CL adds the required pathways to support double-tap-zoom for OOPIF.

1) Modifies WebFrameWidgetImpl to get the box_bounds of the double-
   tapped element, and
2) sends the tapped point and box_bounds to the browser, where
3) RenderFrameHostImpl transforms them into root-view coordinates, and
4) sends them to the renderer via the main-frame's RenderViewHostImpl.
5) From there RenderViewImpl invokes WebViewImpl's
   AnimateDoubleTapZoom.

Bug: 734209
Change-Id: Ic55afb6154356d676872ced93f64a243190cf289
Reviewed-on: https://chromium-review.googlesource.com/c/1298081
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Commit-Position: refs/heads/master@{#612371}
17 files changed
tree: a11e65c4bc4077cccd6b0e49099af1dd56fa125d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .