| commit | dae8af5fe6c8d1c26f489fa103bc51427d72678b | [log] [tgz] |
|---|---|---|
| author | Bence Béky <[email protected]> | Fri Apr 13 08:53:17 2018 |
| committer | Commit Bot <[email protected]> | Fri Apr 13 08:53:17 2018 |
| tree | 139108872c39e9cb41c30330fc414b749cae29f7 | |
| parent | 8f2a9f2aae6a6640c9a1277668aea9b7ae5611b3 [diff] |
Avoid static_cast<SSLClientSocket>(StreamSocket). Move four methods: GetSSLCertRequestInfo(), GetChannelIDService(), GetTokenBindingSignature(), and GetChannelIDKey() from SSLClientSocket to its base class's base class, StreamSocket. Also make GetSSLCertRequestInfo() const. Provide dummy implementations, with NOTREACHED(), in base class, to make it less painful to implement a new derived class. Remove 11 accounts of static_cast<SSLClientSocket*>(StreamSocket). The only remaining invocations are within SSLClientSocketImpl. Bug: 826713 Change-Id: I1f87d31204b95687e6552b7d6f02578de4321eaf Reviewed-on: https://chromium-review.googlesource.com/1010106 Commit-Queue: Bence Béky <[email protected]> Reviewed-by: Istiaque Ahmed <[email protected]> Reviewed-by: Nick Harper <[email protected]> Cr-Commit-Position: refs/heads/master@{#550554}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .