commit dcd8b10251803c2572bb5c45d4535ff19e877a0a
author robpercival <robpercival@chromium.org> Mon Jan 25 19:39:00 2016
committer Commit bot <commit-bot@chromium.org> Mon Jan 25 19:53:44 2016
tree 58cf94b4204d1e202b9324a2cddce94a373ee2e9
parent 4738ec3182c62d726a312f0f882d337744d7c015

Comparison and streaming operators for base::Version

Changes base::Version to comply with updated style guide.

See discussion here:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/8Q6Po7y0Kc4/discussion

Replaces Version::Equals and Version::IsOlderThan.

Review URL: https://codereview.chromium.org/1575523002

Cr-Commit-Position: refs/heads/master@{#371279}

chrome/browser/extensions/extension_service_sync_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc
index a9a05d81..9c55350 100644
--- a/chrome/browser/extensions/extension_service_sync_unittest.cc
+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc
@@ -407,7 +407,7 @@
   EXPECT_EQ(extensions::util::IsIncognitoEnabled(good_crx, profile()),
             data->incognito_enabled());
   EXPECT_EQ(ExtensionSyncData::BOOLEAN_UNSET, data->all_urls_enabled());
-  EXPECT_TRUE(data->version().Equals(*extension->version()));
+  EXPECT_EQ(data->version(), *extension->version());
   EXPECT_EQ(extensions::ManifestURL::GetUpdateURL(extension),
             data->update_url());
   EXPECT_EQ(extension->name(), data->name());
@@ -508,7 +508,7 @@
   EXPECT_EQ(extensions::util::IsIncognitoEnabled(good_crx, profile()),
             data->incognito_enabled());
   EXPECT_EQ(ExtensionSyncData::BOOLEAN_UNSET, data->all_urls_enabled());
-  EXPECT_TRUE(data->version().Equals(*extension->version()));
+  EXPECT_EQ(data->version(), *extension->version());
   EXPECT_EQ(extensions::ManifestURL::GetUpdateURL(extension),
             data->update_url());
   EXPECT_EQ(extension->name(), data->name());
@@ -1061,7 +1061,7 @@
     scoped_ptr<ExtensionSyncData> extension_data =
         ExtensionSyncData::CreateFromSyncData(data[0]);
     ASSERT_TRUE(extension_data);
-    EXPECT_TRUE(installed_version.Equals(extension_data->version()));
+    EXPECT_EQ(installed_version, extension_data->version());
   }
 
   // Should do nothing if extension version > sync version.
@@ -1080,7 +1080,7 @@
     scoped_ptr<ExtensionSyncData> extension_data =
         ExtensionSyncData::CreateFromSyncData(data[0]);
     ASSERT_TRUE(extension_data);
-    EXPECT_TRUE(installed_version.Equals(extension_data->version()));
+    EXPECT_EQ(installed_version, extension_data->version());
   }
 
   // Should kick off an update if extension version < sync version.
@@ -1102,7 +1102,7 @@
     scoped_ptr<ExtensionSyncData> extension_data =
         ExtensionSyncData::CreateFromSyncData(data[0]);
     ASSERT_TRUE(extension_data);
-    EXPECT_TRUE(new_version.Equals(extension_data->version()));
+    EXPECT_EQ(new_version, extension_data->version());
   }
 
   EXPECT_FALSE(service()->pending_extension_manager()->IsIdPending(good_crx));