| commit | ddb1ab17fe48895fa8d1ef920dfe9150ae664715 | [log] [tgz] |
|---|---|---|
| author | Xi Han <[email protected]> | Mon Aug 27 22:18:54 2018 |
| committer | Commit Bot <[email protected]> | Mon Aug 27 22:18:54 2018 |
| tree | c2308cec78d03ebf9424959306b2d3ef35828df2 | |
| parent | e034d1631b4e9a5348403b2ab910caaa9794b7e0 [diff] [blame] |
[FeatureList] Load local state file into a pref_store, and use the pref store to init local state later. [1/3] The reason to create local state in two steps is because we need to read some value from the local state file first, and at that time it's too early to create the full local state object. We read local state file by creating a simple pref_service from the pref_store, and when local state is ready, reset all the objects that uses the simple pref_service to use the full local state. This is the first step to move feature list creation earlier on content_main_runner. We need the simple pref service to create feature list. This CL comes from https://crrev.com/c/1081759. See previous discussion there. More info is available on design doc https://docs.google.com/document/d/1czDvrWU5bE9okOiX-uMwJuZ09SzqxTEW3zHAJG11RVI/edit Bug: 848615, 729596 Change-Id: I3e58768ab68e75d51b9a64155923565823e154e3 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1148959 Reviewed-by: Gabriel Charette <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Commit-Queue: Xi Han <[email protected]> Cr-Commit-Position: refs/heads/master@{#586445}
diff --git a/chrome/browser/chrome_browser_main_posix.h b/chrome/browser/chrome_browser_main_posix.h index 334a2fc..f5d497a 100644 --- a/chrome/browser/chrome_browser_main_posix.h +++ b/chrome/browser/chrome_browser_main_posix.h
@@ -10,9 +10,10 @@ class ChromeBrowserMainPartsPosix : public ChromeBrowserMainParts { public: - explicit ChromeBrowserMainPartsPosix( + ChromeBrowserMainPartsPosix( const content::MainFunctionParams& parameters, - std::unique_ptr<ui::DataPack> data_pack); + std::unique_ptr<ui::DataPack> data_pack, + ChromeFeatureListCreator* chrome_feature_list_creator); // content::BrowserMainParts overrides. int PreEarlyInitialization() override;