Only HistogramBase is used outside of base/metrics.
So client code of histogram will see a simpler interface. This also makes adding SparseHistogram to existing metrics framework possible.
This CL depends on https://codereview.chromium.org/11682003/
So please review that one first.
[email protected],[email protected]
BUG=139612
Review URL: https://chromiumcodereview.appspot.com/11615008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178242 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/content/browser/loader/buffered_resource_handler.cc b/content/browser/loader/buffered_resource_handler.cc
index 3a137098..c212eb9 100644
--- a/content/browser/loader/buffered_resource_handler.cc
+++ b/content/browser/loader/buffered_resource_handler.cc
@@ -37,24 +37,24 @@
void RecordSnifferMetrics(bool sniffing_blocked,
bool we_would_like_to_sniff,
const std::string& mime_type) {
- static base::Histogram* nosniff_usage(NULL);
+ static base::HistogramBase* nosniff_usage(NULL);
if (!nosniff_usage)
nosniff_usage = base::BooleanHistogram::FactoryGet(
- "nosniff.usage", base::Histogram::kUmaTargetedHistogramFlag);
+ "nosniff.usage", base::HistogramBase::kUmaTargetedHistogramFlag);
nosniff_usage->AddBoolean(sniffing_blocked);
if (sniffing_blocked) {
- static base::Histogram* nosniff_otherwise(NULL);
+ static base::HistogramBase* nosniff_otherwise(NULL);
if (!nosniff_otherwise)
nosniff_otherwise = base::BooleanHistogram::FactoryGet(
- "nosniff.otherwise", base::Histogram::kUmaTargetedHistogramFlag);
+ "nosniff.otherwise", base::HistogramBase::kUmaTargetedHistogramFlag);
nosniff_otherwise->AddBoolean(we_would_like_to_sniff);
- static base::Histogram* nosniff_empty_mime_type(NULL);
+ static base::HistogramBase* nosniff_empty_mime_type(NULL);
if (!nosniff_empty_mime_type)
nosniff_empty_mime_type = base::BooleanHistogram::FactoryGet(
"nosniff.empty_mime_type",
- base::Histogram::kUmaTargetedHistogramFlag);
+ base::HistogramBase::kUmaTargetedHistogramFlag);
nosniff_empty_mime_type->AddBoolean(mime_type.empty());
}
}
