Google Git
Sign in
chromium / chromium / src.git / df272efb8f38b128da124c2b1ef9330346a187eb
commitdf272efb8f38b128da124c2b1ef9330346a187eb[log] [tgz]
authorColin Blundell <[email protected]>Wed Jan 10 10:35:46 2018
committerCommit Bot <[email protected]>Wed Jan 10 10:35:46 2018
tree098c1c131c14e0ad630ffb0451072dc50a5bca94
parentd544d115bf1ecfe7687f4b2a448b4f24fbfabc5f [diff]
Convert history to use Identity Service client library

This CL converts //components/history from using //components/signin
to using the Identity Service client library. The conversion is
straightforward:

- Obtain the primary account info via the IdentityManager rather than
  the SigninManager.
- Invalidate access tokens via the IdentityManager rather than
  ProfileOAuth2TokenService.
- Obtain access tokens via a one-shot PrimaryAccountAccessTokenFetcher
  rather than via ProfileOAuth2TokenService.

There is a slight behavioral change as the Identity Service client lib
interacts with ProfileOAuth2TokenService asynchronously to invalidate
access tokens and fetch access tokens. This behavioral change should
not cause any user-visible changes in behavior, as access token fetching
is already asynchronous from the consumer POV and ordering of a call
to invalidate an access token with a subsequent access token fetch is
preserved by design.

I tested the relevant behavior manually by going to chrome://history
for a signed-in and syncing test user and confirming that their
synced history showed up after this change identically to before this
change.

Bug: 796545
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic2cbf966f5bd7c88512ff710bf5d5dba3da613ad
Reviewed-on: https://chromium-review.googlesource.com/846879
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#528275}
9 files changed
tree: 098c1c131c14e0ad630ffb0451072dc50a5bca94
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .