commit | e1c5c8442210bccfbc2475c9bc75a9cf99bb259e | [log] [tgz] |
---|---|---|
author | Bruce Dawson <[email protected]> | Tue Sep 15 02:09:14 2020 |
committer | Commit Bot <[email protected]> | Tue Sep 15 02:09:14 2020 |
tree | 1a32ccee7d878375ba57ac794736c632f9657a45 | |
parent | d3452e93d7893f64bf96dcf8eab008d5b2aabeda [diff] |
Avoid use-after-free SetNotWaitingForResponse can trigger a message pump which can then free the object which |this| points to. This use-after-free can be avoided by not dereferencing |this| after the call, by ensuring that calling SetNotWaitingForResponse is the last thing done. Bug: 1125199 Change-Id: Ie1289c93112151978e6daaa1d24326770028c529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407065 Reviewed-by: Alex Moshchuk <[email protected]> Commit-Queue: Bruce Dawson <[email protected]> Cr-Commit-Position: refs/heads/master@{#806839}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.