Document the use of bisect-builds.py -- for args
When using bisect-builds.py it is often necessary to pass additional
arguments to Chrome but the syntax for doing this is not obvious. This
change explicitly documents the syntax so that I will remember next
time.
Change-Id: I5d19b0fb2eeeea56d96b9823c1c5106aa79d16d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274082
Commit-Queue: Bruce Dawson <[email protected]>
Reviewed-by: David Bienvenu <[email protected]>
Reviewed-by: Jesse McKenna <[email protected]>
Cr-Commit-Position: refs/heads/master@{#783729}
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
index 8a29c982..9efc7bfa 100755
--- a/tools/bisect-builds.py
+++ b/tools/bisect-builds.py
@@ -1077,7 +1077,9 @@
' Chrome\'s about: build number and omahaproxy branch_revision\n'
' are incorrect, they are from branches.\n'
'\n'
- 'Tip: add "-- --no-first-run" to bypass the first run prompts.')
+ 'Use "-- <args-to-pass-to-chromium>" to pass arbitrary extra \n'
+ 'arguments to the test binaries.\n'
+ 'E.g., add "-- --no-first-run" to bypass the first run prompts.')
parser = optparse.OptionParser(usage=usage)
# Strangely, the default help output doesn't include the choice list.
choices = ['mac', 'mac64', 'win', 'win64', 'linux', 'linux64', 'linux-arm',
@@ -1113,14 +1115,17 @@
default=1,
help='Number of times to run each build before asking '
'if it\'s good or bad. Temporary profiles are reused.')
- parser.add_option('-c', '--command',
+ parser.add_option('-c',
+ '--command',
type='str',
default='%p %a',
help='Command to execute. %p and %a refer to Chrome '
- 'executable and specified extra arguments '
- 'respectively. Use %s to specify all extra arguments '
- 'as one string. Defaults to "%p %a". Note that any '
- 'extra paths specified should be absolute.')
+ 'executable and specified extra arguments respectively. '
+ 'Use %s to specify all extra arguments as one string. '
+ 'Defaults to "%p %a". Note that any extra paths specified '
+ 'should be absolute. If you just need to append an '
+ 'argument to the Chrome command line use "-- '
+ '<args-to-pass-to-chromium>" instead.')
parser.add_option('-l', '--blink',
action='store_true',
help='Use Blink bisect instead of Chromium. ')