| commit | e9d1fa7673f2c99d0dfca881033b695e8ed61d1f | [log] [tgz] |
|---|---|---|
| author | dpapad <[email protected]> | Thu Jun 09 17:42:50 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Jun 09 17:42:50 2022 |
| tree | fc932b741a811b4a888b181f30697d2f1787aada | |
| parent | 131867a175f3b81ba095a8b0846ae900bb902908 [diff] |
WebUI: Enforce class properties naming with ESLint checks for TS files.
Specifically enforcing the following rules from the styleguide at [1]:
1) Class properties should be using lowerCamelCase
2) Class properties that are 'static readonly' should be using
CONSTANT_CASE
As part of enabling the new check fixed or suppressed any violations
revealed with
git cl presubmit --files "*.ts"
[1] https://google.github.io/styleguide/tsguide.html#identifiers
Bug: 720034
Change-Id: I4a50e986a96d3037ef36e7c6feb349a53ba5d461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696562
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1012589}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.