Google Git
Sign in
chromium / chromium / src.git / ea0d99ea4f289a7bf735edaed85bcb5f712507eb
commitea0d99ea4f289a7bf735edaed85bcb5f712507eb[log] [tgz]
authorFady Samuel <[email protected]>Thu Sep 28 02:21:07 2017
committerCommit Bot <[email protected]>Thu Sep 28 02:21:07 2017
tree0fcbb2d0f782eceeeb70eb8384bbfbbc4f5f59e0
parent86f6ae0fa5efc263aa6b6b820eed3b9b90b66c32 [diff]
Surface synchronization: Simplify OOPIF and BrowserPlugin

With CL 669444, if a primary SurfaceInfo is specified on a layer
and no fallback is specified, then SurfaceAggregator will use an
embedder provided default background color to fill the space of the
primary Surface if the primary Surface is unavailable at surface
aggregation time.

Previously, SurfaceAggregator reported this case as an error and
logged UMA for a missing surface. Given this state is no longer considered
an error, there is room for simplifying code in BrowserPlugin and
RenderFrameProxy.

The default background color is set to SK_ColorTRANSPARENT to match the
current behavior. The primary surface is set as soon as it can be and
doesn't wait for the first fallback surface to become available.

Bug: 672962
Change-Id: I0ec6153356978e8994b50bfd4a024369e6f320d7
Reviewed-on: https://chromium-review.googlesource.com/686354
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/heads/master@{#504869}
6 files changed
tree: 0fcbb2d0f782eceeeb70eb8384bbfbbc4f5f59e0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .