Fix several issues with popup window locations:
1) Remove ConstrainedWindow::GenerateInitialBounds(), which is old and crufty and no longer relevant now that there are no unsuppressed, constrained popup windows.
2) Move the browser side positioning logic into Browser::BuildPopupWindow().
3) Fix the window.open() handler so that when we aren't given top=/left= coordinates, we don't set the window origin (allowing the browser to do something more intelligent).
BUG=1290758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@325 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/tab_contents.cc b/chrome/browser/tab_contents.cc
index 7f6c9e8..24bae60b 100644
--- a/chrome/browser/tab_contents.cc
+++ b/chrome/browser/tab_contents.cc
@@ -234,15 +234,7 @@
if ((disposition == NEW_POPUP) && !delegate_->IsPopup(this)) {
if (user_gesture) {
- // TODO(erg): Need a better policy about initial placement of
- // popup windows.
- gfx::Rect initial_bounds = initial_pos;
- if (initial_bounds.x() == 0 || initial_bounds.y() == 0) {
- ConstrainedWindow::GenerateInitialBounds(
- initial_pos, this, &initial_bounds);
- }
-
- delegate_->AddNewContents(this, new_contents, disposition, initial_bounds,
+ delegate_->AddNewContents(this, new_contents, disposition, initial_pos,
user_gesture);
} else {
AddConstrainedPopup(new_contents, initial_pos);
