Google Git
Sign in
chromium / chromium / src.git / eb39fc23e374dcf484109315255be983592a1acd
commiteb39fc23e374dcf484109315255be983592a1acd[log] [tgz]
authorMugdha Lakhani <[email protected]>Thu Nov 14 14:54:25 2019
committerCommit Bot <[email protected]>Thu Nov 14 14:54:25 2019
treecae1f8145df94fb369e42f0dac6738787becfb0e
parent7a18f0ba75a32b1dbf8b493d936c49aa1eedafcb [diff]
[Background Sync] Move browser wakeup to scheduler.

Before this chance, we were calculating the soonest wakeup_delta across
all storage partitions every time there was a change in state of any
storage partition, to schedule a wakeup task with this delta.

This change builds on the fact that we have running timers representing
delays for each of the storage partitions with active registrations in
the scheduler. I've changed scheduling the wakeup task to a push system.
Each storage partition informs the scheduler of its soonest delay after
there's any change in state. If this requested delay is the smallest of
all the current delays of the timers the scheduler has, it schedules a
wakeup task.

Canceling delayed scheduling causes cancellation of the wakeup task if
none of the storage partitions need it.

The change also removes now unnecessary code.
Unit tests are also added, and integration tests updated.

Bug: 996166
Change-Id: I1e6216ecc7085535a8e0ca0075ddad05085df763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834086
Commit-Queue: Mugdha Lakhani <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Auto-Submit: Mugdha Lakhani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#715262}
13 files changed
tree: cae1f8145df94fb369e42f0dac6738787becfb0e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .