Google Git
Sign in
chromium / chromium / src.git / ec4cbcdfb10cb834da471bdce4af0efd954af5a9
commitec4cbcdfb10cb834da471bdce4af0efd954af5a9[log] [tgz]
authorDavid Black <[email protected]>Wed Apr 15 20:35:25 2020
committerCommit Bot <[email protected]>Wed Apr 15 20:35:25 2020
treeaf5b2d2bc158a101b9349f373fd8ca76e0c885f2
parent1a2b208cb235c363beea2470076164ecfc1cc432 [diff]
Creates public interface for AssistantController.

This CL:
- Creates public interface for AssistantController
- Renames existing AssistantController to AssistantControllerImpl
- Updates references

This new interface (which exposes a singleton accessor) will be used
moving forward to get a handle to the AssistantController from outside
of Ash. The most pressing need for this is the new Assistant search
provider.

Note that this CL doesn't yet add public APIs onto the interface, as I
attempted to only make the smallest possible change in this CL.

Follow up CLs will migrate public APIs onto the interface as well as
remove the existing accessor to AssistantController that is currently
exposed through Shell so that we can enforce consistent access to
AssistantController through this new public API moving forward.

Bug: b:146074655
Change-Id: Id9f414f66fbfc60c90eb5d0c8a9b86681c641da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148098
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#759399}
49 files changed
tree: af5b2d2bc158a101b9349f373fd8ca76e0c885f2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.