Revert "Enable the seccomp-bpf sandbox for the Android photo picker"
This reverts commit 836222319593ae0e12107a5723d82e0d724c9b4a.
Reason for revert: Caused test failures on https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44157
org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testSingleSelectionPhoto
org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testMultiSelectionPhoto
org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testNoSelection
Original change's description:
> Enable the seccomp-bpf sandbox for the Android photo picker
>
> This CL attempts to enable the seccomp-bpf sandbox, as we do for
> renderer processes on Android, for the new photo picker when it is
> supported by the device.
>
> The implementation loads the native library as if it's a Chrome child
> process, and then calls the native InitializePhotoPickerSandbox function
> to initialize the sandbox when available. UMA is logged.
>
> Because we end up loading the native library, this does create for an
> additional delay of ~700ms before the first photo is shown. There may be
> optimization opportunities by separating out the sandbox code in a separate
> shared library, but this is made difficult by (a) our build system using
> the crazy linker, and (b) the dependencies of //sandbox on //base.
>
> I've verified that the sandbox is enabled on two devices running
> different versions of Android, both by printing the status of the
> SeccompStarterAndroid, and through the following command:
>
> $ adb shell cat /proc/18424/status | grep Seccomp
> Seccomp: 2
>
> (Where "2" means that seccomp-bpf is enabled.)
>
> BUG=730066
>
> Change-Id: I46e608bad8f69d3cf862c0953361c50f4c65c45c
> Reviewed-on: https://chromium-review.googlesource.com/577853
> Reviewed-by: David Trainor <[email protected]>
> Reviewed-by: Jorge Lucangeli Obes <[email protected]>
> Reviewed-by: Bo Liu <[email protected]>
> Reviewed-by: Ilya Sherman <[email protected]>
> Commit-Queue: Peter Beverloo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#488643}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: I2b0d24e90ce50bf2bc913cc7219f48475a34bbda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 730066
Reviewed-on: https://chromium-review.googlesource.com/581628
Reviewed-by: Ojan Vafai <[email protected]>
Commit-Queue: Ojan Vafai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#488686}5 files changed
