| commit | ed1a48961905654e314a6271b072f81becbc9283 | [log] [tgz] |
|---|---|---|
| author | Mustafa Emre Acer <[email protected]> | Tue Jun 30 19:15:39 2020 |
| committer | Commit Bot <[email protected]> | Tue Jun 30 19:15:39 2020 |
| tree | 8bbc2d34ce00df42336da61cba0931b270a55efd | |
| parent | 24351745df7fa707b86d3bfe36f663cc06c557b7 [diff] |
Skip screenshot checks for strings marked with is_accessibility=true We require translation screenshots for strings in grd and grdp files. It's been noted that some of these strings are accessibility labels, and they aren't displayed in Chrome UI. This CL introduces a new tag to mark strings that are used as accessibility labels (is_accessibility=true). If a UI message has this tag, it'll be excluded from translation screenshot checks in the presubmit. Bug: 1094077 Change-Id: I204d068264ff0d0305d1d8afd48de516f9a26ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274667 Reviewed-by: Dirk Pranke <[email protected]> Reviewed-by: Lei Zhang <[email protected]> Commit-Queue: Mustafa Emre Acer <[email protected]> Cr-Commit-Position: refs/heads/master@{#784078}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.