| commit | edba1f550acda808d68f6f81a2c6cfd3ab48e130 | [log] [tgz] |
|---|---|---|
| author | Qasid Sadiq <[email protected]> | Mon Apr 05 18:56:03 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Mon Apr 05 18:56:03 2021 |
| tree | a4b080d3fea8d3a8f7fa84028acc443e070a8849 | |
| parent | 4225d11d2e2cb0f1ca3f16ec42368d14850e41b9 [diff] |
wallpaper: we can't use chrome.storage, use PrefService instead. WallpaperInfo is currently stored using chrome.storage, and redundantly PrefService in wallpaper_controller_impl, behind [Get|Set]UserWallpaperInfo. chrome.storage was used to sync info across devices. Let's handle syncing in the wallpaper_controller through profile prefs. Migrate to the new prefs in whenever a new profile pref service becomes active, and the migration hasn't already happened. We have two kinds of wallpaperInfo storage. kSyncedWallpaperInfo in profile Prefs. kLocalWallpaperInfo in local state. The wallpaper type determines if it belongs in kLocalWallpaperInfo or kSyncedWallpaperInfo. If a wallpaper is syncable, it is stored in kSyncedWallpaperInfo. The info in local state is what is read to display a wallpaper. The info in profile prefs is used to sync to other devices and hold onto the info, while the actual image becomes available. Tests: Added wallpaper_controller_unittest.cc tests. testing/xvfb.py ./out/Debug/ash_unittests --gtest_filter="*WallpaperControllerTest*" Used logs to verify the data being migrated is the correct data. And tested by hand, turning on the feature flag will disable syncing in the old app, and enable it in the new place. You can see online syncing (as long as the wallpaper is already downloaded), and default syncing. Bug: b/178016374 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ia4132a753598907bddf5e673652a70af1a3ecc11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2714427 Reviewed-by: Jun Mukai <[email protected]> Reviewed-by: Toni Baržić <[email protected]> Reviewed-by: Jeffrey Young <[email protected]> Reviewed-by: Xiaohui Chen <[email protected]> Reviewed-by: Tao Wu <[email protected]> Commit-Queue: Qasid Sadiq <[email protected]> Auto-Submit: Qasid Sadiq <[email protected]> Cr-Commit-Position: refs/heads/master@{#869221}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.