| commit | eddf1b84052d69fe1250f23c8119e545e05f740e | [log] [tgz] |
|---|---|---|
| author | Bruce Dawson <[email protected]> | Wed Apr 08 17:23:19 2020 |
| committer | Commit Bot <[email protected]> | Wed Apr 08 17:23:19 2020 |
| tree | a6ecc65036bf0b88b10ab9b7f48956d7a1ff7f22 | |
| parent | 5965d826d4c4072d1085c630b5e1a5bd1f85c4f8 [diff] |
Don't close process handle early in ServiceProcessControlBrowserTest In the Setup() function for ServiceProcessControlBrowserTest the process handle is closed (on all platforms) in order to avoid unspecified failures on MACOSX. However doing this means that the error code checking in TearDown() is never run. This hides an apparent bug on Linux and avoids useful error checking on other platforms. This change makes it so that Close() is only called early on platforms where it is necessary. Bug: 1059446 Change-Id: I5a408e92a5587a8f52718b6c56660453abce5eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137856 Auto-Submit: Bruce Dawson <[email protected]> Commit-Queue: Wei Li <[email protected]> Reviewed-by: Wei Li <[email protected]> Cr-Commit-Position: refs/heads/master@{#757479}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.