FrameHost::SubresourceResponseStarted: s/ url / origin_of_final_url /.
This CL changes the following method of content::mojom::FrameHost from:
SubresourceResponseStarted(url.mojom.Url url, uint32 cert_status);
to:
SubresourceResponseStarted(
url.mojom.Origin origin_of_final_response_url,
uint32 cert_status);
because it turns out that implementations of that method only ever
depend on the origin of the final URL (and not on other parts of
the full URL like path or query).
Bug: 973885
Change-Id: If73a905e856640cd2959063faae4033f01788a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899739
Commit-Queue: Łukasz Anforowicz <[email protected]>
Auto-Submit: Łukasz Anforowicz <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#716451}
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e37a407..fb62a28 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4467,7 +4467,7 @@
if (navigation_handle->IsInMainFrame() &&
navigation_handle->GetNetErrorCode() == net::OK) {
controller_.ssl_manager()->DidStartResourceResponse(
- navigation_handle->GetURL(),
+ url::Origin::Create(navigation_handle->GetURL()),
navigation_handle->GetSSLInfo().has_value()
? net::IsCertStatusError(
navigation_handle->GetSSLInfo()->cert_status)
@@ -4819,9 +4819,11 @@
// AddNewContents method call.
}
-void WebContentsImpl::SubresourceResponseStarted(const GURL& url,
- net::CertStatus cert_status) {
- controller_.ssl_manager()->DidStartResourceResponse(url, cert_status);
+void WebContentsImpl::SubresourceResponseStarted(
+ const url::Origin& origin_of_final_response_url,
+ net::CertStatus cert_status) {
+ controller_.ssl_manager()->DidStartResourceResponse(
+ origin_of_final_response_url, cert_status);
SetNotWaitingForResponse();
}
