[LargeSplash:2]Make WebAPK install include splash icon image data from hasher
This CL removes badge icon from webapk&shortcut install, including a2hs
and app banner.
For splash icon, we want to fetch it for building the webapk proto, but
don't want to do it together with primary icon, because it'll increase
latency, and we only need the splash icon data after the user has
initiated the install.
For webapks, we are downloading all useful image data when computing
the murmur2 hash, so we can use the the image data from
webapk_icon_hasher, similar to crrev.com/c/2047166 did for the
best shortcut icon.
Bug: 1043271
Change-Id: Ibbe5b80796794b3f1c4b75cd81cdfc32cc61dfff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032723
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Peter Kotwicz <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Cr-Commit-Position: refs/heads/master@{#744134}
diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc
index dde3a09..f86c8660 100644
--- a/chrome/browser/android/shortcut_helper.cc
+++ b/chrome/browser/android/shortcut_helper.cc
@@ -155,14 +155,12 @@
std::unique_ptr<ShortcutInfo> ShortcutHelper::CreateShortcutInfo(
const GURL& manifest_url,
const blink::Manifest& manifest,
- const GURL& primary_icon_url,
- const GURL& badge_icon_url) {
+ const GURL& primary_icon_url) {
auto shortcut_info = std::make_unique<ShortcutInfo>(GURL());
if (!manifest.IsEmpty()) {
shortcut_info->UpdateFromManifest(manifest);
shortcut_info->manifest_url = manifest_url;
shortcut_info->best_primary_icon_url = primary_icon_url;
- shortcut_info->best_badge_icon_url = badge_icon_url;
}
shortcut_info->ideal_splash_image_size_in_px = GetIdealSplashImageSizeInPx();
