Fix crash in chromoting host when audio is disabled.
The host was trying to initialize audio stream when audio is disabled,
and was crashing as result. Updated ClientSession to create AudioStream
only when DesktopEnvironemt::CreateAudioCapturer() returns a capturer.
Review-Url: https://codereview.chromium.org/2408883002
Cr-Commit-Position: refs/heads/master@{#424431}
diff --git a/remoting/host/client_session.cc b/remoting/host/client_session.cc
index 76c9929b..6317d2ab 100644
--- a/remoting/host/client_session.cc
+++ b/remoting/host/client_session.cc
@@ -281,8 +281,11 @@
desktop_environment_->CreateVideoCapturer());
// Create a AudioStream to pump audio from the capturer to the client.
- audio_stream_ = connection_->StartAudioStream(
- desktop_environment_->CreateAudioCapturer());
+ std::unique_ptr<protocol::AudioSource> audio_capturer =
+ desktop_environment_->CreateAudioCapturer();
+ if (audio_capturer) {
+ audio_stream_ = connection_->StartAudioStream(std::move(audio_capturer));
+ }
video_stream_->SetObserver(this);