Google Git
Sign in
chromium / chromium / src.git / f0527a9b0c9321be0b6fd9f0fe118d4c01005e22
commitf0527a9b0c9321be0b6fd9f0fe118d4c01005e22[log] [tgz]
authorAlex Clarke <[email protected]>Wed Jan 23 10:43:25 2019
committerCommit Bot <[email protected]>Wed Jan 23 10:43:25 2019
tree189947354a7643c0e747b0658c2ede75b7d97901
parent9a9ccbc08949a7936b803e58117a57cc26b46de8 [diff]
Make it easier to use traits with TestBrowserThreadBundle

All those default values made TestBrowserThreadBundle's constructor
(and ChromeRenderViewHostTestHarness and BrowserWithTestWindowTest)
awkward to use and maintain (imagine if we added another trait to
ScopedTaskEnvironment).  This patch changes TestBrowserThreadBundle's
main constructor to take zero or more traits to configure the
TestBrowserThreadBundle and the underlying ScopedTaskEnvironment.

Note there is a 20kb test binary size hit which we are happy to
take in favour of readability for tests but that this paradigm
should be used with care on non-constexpr types in prod.

A number of clients of TestBrowserThreadBundle are also refactored to
take advantage of this.

Change-Id: I2bdb3b8c382f1389058508f870815eddb500726d
Bug: 881041
Reviewed-on: https://chromium-review.googlesource.com/c/1394377
Commit-Queue: Alex Clarke <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Naoki Fukino <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#625158}
41 files changed
tree: 189947354a7643c0e747b0658c2ede75b7d97901
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .